-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kms/attestations/ directory with sample script to verify attestations #3262
Conversation
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also get technical review. :)
In case you don't have access to the logs:
Pytho builds failed with:
I think you have to rebase to github master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't point it out in the first pass, but I think it is harmful to completely swallow exceptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
…ions [(#3262)](#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
…ions [(#3262)](#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
…ions [(#3262)](#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
…ions [(#3262)](#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
…ions [(#3262)](#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
This adds a kms/attestations/ directory to hold code samples that deal with attestations and certificates obtained from Cloud HSM. This also adds a verify_attestation.py script to verify attestations using certificate bundles containing one or more certificates.
fixes #3246