Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README with instructions for running #97

Merged
merged 13 commits into from
Apr 6, 2022

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Apr 1, 2022

Updates README with additional instructions for how to run PGAdapter:

  • Using a pre-built Docker image.
  • Using a pre-built uber-jar.

Also adds separate documentation files for commonly used tools/drivers with specific instructions for those tools/drivers. The latter is to a certain degree a placeholder for more documentation to come.

Updated README with additional options for how to run PGAdapter. Also
added separate documentation files for commonly used tools/drivers with
specific instructions for those tools/drivers. The latter is to a
certain degree a placeholder for more documentation to come.
@olavloite olavloite marked this pull request as ready for review April 1, 2022 12:09
Copy link

@snehashah16 snehashah16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a ton of nit comments..

generally, lets keep it clean and easy to maintain.

@olavloite olavloite requested a review from snehashah16 April 6, 2022 13:07
Copy link

@snehashah16 snehashah16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, LGTM otherwise

@olavloite olavloite enabled auto-merge (squash) April 6, 2022 20:00
@olavloite olavloite merged commit bab6106 into postgresql-dialect Apr 6, 2022
@olavloite olavloite deleted the docs-for-running-pgadapter branch April 6, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants