Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce parsing of sql string #79

Merged
merged 2 commits into from
Apr 1, 2022
Merged

perf: reduce parsing of sql string #79

merged 2 commits into from
Apr 1, 2022

Conversation

olavloite
Copy link
Collaborator

Performance optimisations and cleanups:

  • Reduce the number of times a SQL string is parsed and passed around.
  • Make as many properties as possible final
  • Clean up constructor hierarchy of portal statements
  • Add quick return for simple case of splitting statements

@olavloite
perf: reduce parsing of sql string
ea7f96d 
Reduce the number of times a SQL string is parsed and passed around. Also make as many
properties final as possible and clean up constructor hierarchy.
@olavloite olavloite merged commit 4c24ef9 into postgresql-dialect Apr 1, 2022
@olavloite olavloite deleted the reduce-parsing branch April 1, 2022 15:24
@release-please release-please bot mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratickchokhani pratickchokhani Awaiting requested review from pratickchokhani

@gauravsnj gauravsnj Awaiting requested review from gauravsnj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@olavloite