Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support information_schema.sequences #708

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

olavloite
Copy link
Collaborator

Adds support for information_schema.sequences using a common table expression. The CTE always returns zero rows and is there purely for compatibility reasons.

Towards #705

Adds support for information_schema.sequences using a common table
expression. The CTE always returns zero rows and is there purely for
compatibility reasons.

Towards #705
@olavloite olavloite enabled auto-merge (squash) March 6, 2023 13:28
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #708 (e1cf0cf) into postgresql-dialect (37ce315) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e1cf0cf differs from pull request most recent head 99c9a7b. Consider uploading reports for the commit 99c9a7b to get more accurate results

@@                  Coverage Diff                  @@
##             postgresql-dialect     #708   +/-   ##
=====================================================
  Coverage                 89.35%   89.35%           
- Complexity                 2302     2305    +3     
=====================================================
  Files                       126      126           
  Lines                      7588     7591    +3     
  Branches                   1089     1090    +1     
=====================================================
+ Hits                       6780     6783    +3     
  Misses                      560      560           
  Partials                    248      248           
Flag Coverage Δ
all_tests 89.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cloud/spanner/pgadapter/statements/PgCatalog.java 96.69% <100.00%> (+0.08%) ⬆️
...ud/spanner/pgadapter/utils/ClientAutoDetector.java 91.91% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite olavloite merged commit c043c46 into postgresql-dialect Mar 6, 2023
@olavloite olavloite deleted the information-schema-sequences branch March 6, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants