feat: support Connection API options in connection string #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL supports sending session configuration parameters in the Startup message. These can be embedded in the connection string of many clients, such as JDBC. This worked for session configuration parameters that are maintained in PGAdapter, but not for the very specific session configuration parameters that are maintained by the Connection API, such as `spanner.autocommit_dml_mode` or `spanner.read_only_staleness`. This PR adds support for those session options in the StartupMessage.
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #542 +/- ##
========================================================
+ Coverage 88.39% 88.41% +0.01%
- Complexity 2068 2069 +1
========================================================
Files 122 122
Lines 6783 6791 +8
Branches 954 956 +2
========================================================
+ Hits 5996 6004 +8
Misses 558 558
Partials 229 229
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
olavloite
requested review from
fenilfadadu,
gauravsnj,
pratickchokhani and
manu2
pratickchokhani
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL supports sending session configuration parameters in the Startup message. These can be embedded in the connection string of many clients, such as JDBC. This worked for session configuration parameters that are maintained in PGAdapter, but not for the very specific session configuration parameters that are maintained by the Connection API, such as
spanner.autocommit_dml_modeorspanner.read_only_staleness. This PR adds support for those session options in the StartupMessage.