-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for Django specific statement #382
Conversation
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #382 +/- ##
========================================================
+ Coverage 86.36% 86.41% +0.05%
- Complexity 1844 1847 +3
========================================================
Files 121 122 +1
Lines 6056 6064 +8
Branches 838 838
========================================================
+ Hits 5230 5240 +10
+ Misses 594 592 -2
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
import com.google.common.collect.ImmutableList; | ||
|
||
@InternalApi | ||
public class DjangoSpecificStatement implements LocalStatement { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could we rename this to something like DjangoGetTableNamesStatement
and add a comment that this statement is used by Django to check whether the migrations
tables exists. If it does not, then Django will assume that migrations are disabled, which makes it safe to mock this statement with an empty result set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
No description provided.