docs: Hibernate sample #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
commented
Oct 4, 2022
...es/java/hibernate/src/main/java/com/google/cloud/postgres/models/HibernateConfiguration.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #373 +/- ##
========================================================
+ Coverage 86.32% 87.70% +1.37%
- Complexity 1914 2049 +135
========================================================
Files 122 123 +1
Lines 6216 6799 +583
Branches 849 972 +123
========================================================
+ Hits 5366 5963 +597
+ Misses 605 587 -18
- Partials 245 249 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
olavloite
commented
Oct 6, 2022
samples/java/hibernate/src/main/java/com/google/cloud/postgres/HibernateSampleTest.java
Show resolved
Hide resolved
samples/java/hibernate/src/main/java/com/google/cloud/postgres/HibernateSampleTest.java
Outdated
Show resolved
Hide resolved
samples/java/hibernate/src/main/java/com/google/cloud/postgres/HibernateSampleTest.java
Outdated
Show resolved
Hide resolved
samples/java/hibernate/src/main/java/com/google/cloud/postgres/HibernateSampleTest.java
Show resolved
Hide resolved
samples/java/hibernate/src/main/java/com/google/cloud/postgres/CustomValueGenerator.java
Outdated
Show resolved
Hide resolved
…gadapter into hibernate-sample
…gadapter into hibernate-sample
2. Fixed README.md
| list = query.list(); | ||
| System.out.println("Singers list size with first result: " + list.size()); | ||
|
|
||
| /* Current Limit is not supported. */ |
There was a problem hiding this comment.
Marked this as not supported as the change is not published in PROD. Will update this when the change is published
olavloite
commented
Nov 4, 2022
| @Entity | ||
| public class Tracks { | ||
|
|
||
| @EmbeddedId private TracksId id; |
There was a problem hiding this comment.
I think it would be good to add a comment here that explains what we are doing to model an interleaved table.
There was a problem hiding this comment.
This is not specific to interleaved table. It will have to be done for every composite primary key. Which is standard across hibernate
| import javax.persistence.Embeddable; | ||
|
|
||
| @Embeddable | ||
| public class TracksId implements Serializable { |
There was a problem hiding this comment.
Also here: I think it would be good to add a small comment on why we are creating this embeddable ID.
src/test/java/com/google/cloud/spanner/pgadapter/hibernate/ITHibernateTest.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| // Write liquibase.properties |
There was a problem hiding this comment.
Do a search-and-replace liquibase -> Hibernate ;-)
Co-authored-by: Knut Olav Løite <[email protected]>
Co-authored-by: Knut Olav Løite <[email protected]>
Co-authored-by: Knut Olav Løite <[email protected]>
Co-authored-by: Knut Olav Løite <[email protected]>
Co-authored-by: Knut Olav Løite <[email protected]>
Co-authored-by: Knut Olav Løite <[email protected]>
…ibernateTest.java Co-authored-by: Knut Olav Løite <[email protected]>
2. Copyrights added 3. Nit fixes
…gadapter into hibernate-sample
…gadapter into hibernate-sample
pratickchokhani
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hibernate Sample which depicts how hibernate can be implemented with PgAdpter. It also contains the README file detailing the limitation of Hibernate.
Integration test for Hibernate is also added.