Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow 'T' in timestamp values in COPY operations #319

Merged
merged 7 commits into from
Aug 23, 2022

Conversation

olavloite
Copy link
Collaborator

COPY operations used the TimestampUtils from the PG JDBC driver. This
class does not accept timestamp values that contain a 'T' as a separator
between the date and time value. Instead, we'll rely on our own
Timestamp parser that we already have in place for wire-protocol
conversion.

Fixes b/240602999

COPY operations used the TimestampUtils from the PG JDBC driver. This
class does not accept timestamp values that contain a 'T' as a separator
between the date and time value. Instead, we'll rely on our own
Timestamp parser that we already have in place for wire-protocol
conversion.

Fixes b/240602999
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

❗ No coverage uploaded for pull request base (postgresql-dialect@2c36c6e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1ca4f7b differs from pull request most recent head 696e565. Consider uploading reports for the commit 696e565 to get more accurate results

@@                  Coverage Diff                  @@
##             postgresql-dialect     #319   +/-   ##
=====================================================
  Coverage                      ?   83.66%           
  Complexity                    ?     1512           
=====================================================
  Files                         ?      113           
  Lines                         ?     5199           
  Branches                      ?      674           
=====================================================
  Hits                          ?     4350           
  Misses                        ?      636           
  Partials                      ?      213           
Flag Coverage Δ
all_tests 83.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite olavloite merged commit a239328 into postgresql-dialect Aug 23, 2022
@olavloite olavloite deleted the allow-t-in-timestamp branch August 23, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant