Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backslash is not a valid quote escape #317

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

olavloite
Copy link
Collaborator

The SimpleParser would accept backslash+quote as a valid escape mechanism
for a quote inside a quoted string. This is not correct for PostgreSQL,
and instead should be two equal quotes directly following each other.

The SimpleParser would accept backslash+quote as a valid escape mechanism
for a quote inside a quoted string. This is not correct for PostgreSQL,
and instead should be two equal quotes directly following each other.
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #317 (f04538e) into postgresql-dialect (819a653) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##             postgresql-dialect     #317      +/-   ##
========================================================
+ Coverage                 83.02%   83.04%   +0.02%     
- Complexity                 1450     1453       +3     
========================================================
  Files                       113      113              
  Lines                      5077     5085       +8     
  Branches                    653      657       +4     
========================================================
+ Hits                       4215     4223       +8     
  Misses                      650      650              
  Partials                    212      212              
Flag Coverage Δ
all_tests 83.04% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oud/spanner/pgadapter/statements/SimpleParser.java 95.07% <100.00%> (+0.29%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite olavloite merged commit dc32af4 into postgresql-dialect Aug 15, 2022
@olavloite olavloite deleted the fix-quote-escape branch August 15, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant