feat: ignore named primary keys with correct name #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CREATE TABLE statements that contain a named primary key constraint are rejected by the backend, as the name of a primary key is fixed to 'PK_<table_name>'. This change parses and removes named primary key constraint from CREATE TABLE statements when these specify the same name as the generated name. This enables the usage of frameworks that always generate CREATE TABLE statements with a named primary key constraint, as long as the name that has been configured is equal to the fixed name. The fact that the named constraint is stripped from the DDL statement does not have any effect on the result of the statement, as the generated name will be equal to the name specified in the statement.
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #286 +/- ##
========================================================
+ Coverage 82.61% 82.69% +0.08%
- Complexity 1306 1315 +9
========================================================
Files 107 107
Lines 4521 4554 +33
Branches 559 568 +9
========================================================
+ Hits 3735 3766 +31
- Misses 600 601 +1
- Partials 186 187 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
pratickchokhani
pushed a commit
that referenced
this pull request
Jul 25, 2022
CREATE TABLE statements that contain a named primary key constraint are rejected by the backend, as the name of a primary key is fixed to 'PK_<table_name>'. This change parses and removes named primary key constraint from CREATE TABLE statements when these specify the same name as the generated name. This enables the usage of frameworks that always generate CREATE TABLE statements with a named primary key constraint, as long as the name that has been configured is equal to the fixed name. The fact that the named constraint is stripped from the DDL statement does not have any effect on the result of the statement, as the generated name will be equal to the name specified in the statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CREATE TABLE statements that contain a named primary key constraint are
rejected by the backend, as the name of a primary key is fixed to 'PK_<table_name>'.
This change parses and removes named primary key constraint from CREATE TABLE
statements when these specify the same name as the generated name. This enables
the usage of frameworks that always generate CREATE TABLE statements with a named
primary key constraint, as long as the name that has been configured is equal to
the fixed name. The fact that the named constraint is stripped from the DDL
statement does not have any effect on the result of the statement, as the
generated name will be equal to the name specified in the statement.