Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly skip nested block comments #219

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Conversation

olavloite
Copy link
Collaborator

Block comments with nested block comments were not correctly skipped.
The end tag of a nested block comment would be considered the end of the
entire comment block, instead of only reducing the block comment level.

Fixes b/236784930

Block comments with nested block comments were not correctly skipped.
The end tag of a nested block comment would be considered the end of the
entire comment block, instead of only reducing the block comment level.

Fixes b/236784930
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #219 (8bf821c) into postgresql-dialect (9ec8e67) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@                  Coverage Diff                  @@
##             postgresql-dialect     #219   +/-   ##
=====================================================
  Coverage                 79.73%   79.73%           
- Complexity                 1041     1044    +3     
=====================================================
  Files                        91       91           
  Lines                      3543     3548    +5     
  Branches                    423      425    +2     
=====================================================
+ Hits                       2825     2829    +4     
  Misses                      553      553           
- Partials                    165      166    +1     
Flag Coverage Δ
all_tests 79.73% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cloud/spanner/pgadapter/utils/StatementParser.java 87.09% <83.33%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec8e67...8bf821c. Read the comment docs.

@olavloite olavloite merged commit c9903da into postgresql-dialect Jun 22, 2022
@olavloite olavloite deleted the b-236784930 branch June 22, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants