Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unix domain sockets failed for msg size > 8Kb on MacOS #188

Merged
merged 8 commits into from
Jun 16, 2022

Conversation

olavloite
Copy link
Collaborator

Domain sockets on MacOS failed if it received a message that was bigger than the reader buffer size (8192 bytes).

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #188 (2a2b9f9) into postgresql-dialect (1bf14c8) will not change coverage.
The diff coverage is 66.66%.

❗ Current head 2a2b9f9 differs from pull request most recent head 2f19fdd. Consider uploading reports for the commit 2f19fdd to get more accurate results

@@                  Coverage Diff                  @@
##             postgresql-dialect     #188   +/-   ##
=====================================================
  Coverage                 79.41%   79.41%           
  Complexity                 1041     1041           
=====================================================
  Files                        91       91           
  Lines                      3561     3561           
  Branches                    423      423           
=====================================================
  Hits                       2828     2828           
  Misses                      568      568           
  Partials                    165      165           
Flag Coverage Δ
all_tests 79.41% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...om/google/cloud/spanner/pgadapter/ProxyServer.java 73.33% <0.00%> (ø)
...gle/cloud/spanner/pgadapter/ConnectionHandler.java 76.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf14c8...2f19fdd. Read the comment docs.

@olavloite olavloite marked this pull request as ready for review June 16, 2022 11:06
@olavloite olavloite merged commit bc778ec into postgresql-dialect Jun 16, 2022
@olavloite olavloite deleted the fix-domain-sockets-on-macos branch June 16, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant