Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically detect client that is connected #169

Merged
merged 7 commits into from
Jun 13, 2022

Conversation

olavloite
Copy link
Collaborator

Automatically detects the client that is creating a connection to
PGAdapter based on the data that PGAdapter receives in the
StartupMessage. Not all clients can be uniquely identified this way, and
clients could easily pretend to be a client they are not, but this
feature is only used to automatically apply query replacements based on
the client that is connecting.

Fixes b/235348017

Automatically detects the client that is creating a connection to
PGAdapter based on the data that PGAdapter receives in the
StartupMessage. Not all clients can be uniquely identified this way, and
clients could easily pretend to be a client they are not, but this
feature is only used to automatically apply query replacements based on
the client that is connecting.

Fixes b/235348017
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (postgresql-dialect@30607f0). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             postgresql-dialect     #169   +/-   ##
=====================================================
  Coverage                      ?   78.61%           
  Complexity                    ?      989           
=====================================================
  Files                         ?       89           
  Lines                         ?     3446           
  Branches                      ?      387           
=====================================================
  Hits                          ?     2709           
  Misses                        ?      583           
  Partials                      ?      154           
Flag Coverage Δ
all_tests 78.61% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30607f0...800fc11. Read the comment docs.

@olavloite olavloite marked this pull request as ready for review June 8, 2022 19:24
@olavloite olavloite merged commit f11f459 into postgresql-dialect Jun 13, 2022
@olavloite olavloite deleted the auto-detect-client branch June 13, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant