perf: withstand connect storms #1414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a background worker thread pool to create new connections. This reduces the probability that the client will timeout while waiting for a connection, when a large number of connections are being requested at the same time. Fixes #1377
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## postgresql-dialect #1414 +/- ##
========================================================
- Coverage 90.66% 90.63% -0.03%
- Complexity 2640 2642 +2
========================================================
Files 141 141
Lines 9016 9030 +14
Branches 1313 1314 +1
========================================================
+ Hits 8174 8184 +10
- Misses 567 570 +3
- Partials 275 276 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a background worker thread pool to create new connections. This reduces the probability that the client will timeout while waiting for a connection, when a large number of connections are being requested at the same time.
Fixes #1377