fix: use array lower bound 1 by default #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGAdapter would return arrays in binary format with lower bound 0 (zero) by default. This is not consistent with open-source PostgreSQL, which uses 1 as the default lower bound, and also not consistent with the text format, which does not have a field for returning the lower bound. The lower bound is then assumed to be 1. This changes the default lower bound for binary encoded arrays to 1. Fixes #1259
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## postgresql-dialect #1302 +/- ##
=====================================================
Coverage 89.95% 89.95%
Complexity 2591 2591
=====================================================
Files 141 141
Lines 8889 8889
Branches 1290 1290
=====================================================
Hits 7996 7996
Misses 625 625
Partials 268 268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ankiaga
approved these changes
Dec 26, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PGAdapter would return arrays in binary format with lower bound 0 (zero) by default. This is not consistent with open-source PostgreSQL, which uses 1 as the default lower bound, and also not consistent with the text format, which does not have a field for returning the lower bound. The lower bound is then assumed to be 1. This changes the default lower bound for binary encoded arrays to 1.
Fixes #1259