Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Histogram #129

Closed
TigerHe7 opened this issue Jul 28, 2020 · 4 comments · Fixed by #446
Closed

Add support for Histogram #129

TigerHe7 opened this issue Jul 28, 2020 · 4 comments · Fixed by #446
Assignees
Labels
blocked This issue or pull request is waiting on something else, and isn't actionable right now bug Something isn't working monitoring

Comments

@TigerHe7
Copy link
Contributor

Change Requested:
Add support for OTMetricKind.ValueRecorder from OpenTelemetry SDK.

Current Behavior:
Currently, trying to export metrics collected via ValueRecorder results in an error from Google Cloud Monitoring regarding the MetricKind.UNSPECIFIED being used.

@TigerHe7 TigerHe7 added the bug Something isn't working label Jul 28, 2020
@TigerHe7 TigerHe7 self-assigned this Jul 28, 2020
@aabmass
Copy link
Contributor

aabmass commented Feb 1, 2021

The OTel metrics specification still hasn't decided what default aggregator will be used for ValueRecorder. It's looking like it will be "some histogram sketch" (e.g. DDSketch) which will produce fancy histograms. Since this will be changing, we should put this work off until the JS SDK is up to date.

@aabmass aabmass added monitoring blocked This issue or pull request is waiting on something else, and isn't actionable right now labels Feb 1, 2021
@jonnydgreen
Copy link

Looking at the spec feature freeze milestone, this is due by the end of September 2021: https://github.com/open-telemetry/opentelemetry-specification/milestone/14. If you need, happy to help you both out on an implementation when the default aggregator has been chosen for ValueRecorder and the JS SDK is up to date :)

@aabmass
Copy link
Contributor

aabmass commented Jun 2, 2021

We're always happy to receive PRs 😃 I think this is completely blocked until this work is done in the spec (September timeline) AND its implemented in the JS SDK (maybe later).

@jonnydgreen
Copy link

Now that the Metrics API/SDK spec has reached Feature Freeze, this issue is tracking the required updates to the Metrics SDK to meet the spec: open-telemetry/opentelemetry-js#2574 :)

@aabmass aabmass changed the title Add support for ValueRecorder Add support for Histogram Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue or pull request is waiting on something else, and isn't actionable right now bug Something isn't working monitoring
Projects
None yet
3 participants