-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Histogram #129
Comments
The OTel metrics specification still hasn't decided what default aggregator will be used for ValueRecorder. It's looking like it will be "some histogram sketch" (e.g. DDSketch) which will produce fancy histograms. Since this will be changing, we should put this work off until the JS SDK is up to date. |
Looking at the spec feature freeze milestone, this is due by the end of September 2021: https://github.com/open-telemetry/opentelemetry-specification/milestone/14. If you need, happy to help you both out on an implementation when the default aggregator has been chosen for ValueRecorder and the JS SDK is up to date :) |
We're always happy to receive PRs 😃 I think this is completely blocked until this work is done in the spec (September timeline) AND its implemented in the JS SDK (maybe later). |
Now that the Metrics API/SDK spec has reached Feature Freeze, this issue is tracking the required updates to the Metrics SDK to meet the spec: open-telemetry/opentelemetry-js#2574 :) |
Change Requested:
Add support for
OTMetricKind.ValueRecorder
from OpenTelemetry SDK.Current Behavior:
Currently, trying to export metrics collected via
ValueRecorder
results in an error from Google Cloud Monitoring regarding theMetricKind.UNSPECIFIED
being used.The text was updated successfully, but these errors were encountered: