We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#452 introduced a new diff when recording new fixtures:
$ exporter/collector/integrationtest$ go run cmd/recordfixtures/main.go ... $ git diff diff --git a/exporter/collector/integrationtest/testdata/fixtures/metrics_multi_project_expected.json b/exporter/collector/integrationtest/testdata/fixtures/metrics_multi_project_expected.json index c513b6e..92ab158 100644 --- a/exporter/collector/integrationtest/testdata/fixtures/metrics_multi_project_expected.json +++ b/exporter/collector/integrationtest/testdata/fixtures/metrics_multi_project_expected.json @@ -1,7 +1,7 @@ { "createTimeSeriesRequests": [ { - "name": "projects/fake-other-project", + "name": "projects/fakeprojectid", "timeSeries": [ { "metric": { @@ -352,7 +352,7 @@ ] }, { - "name": "projects/fakeprojectid", + "name": "projects/fake-other-project", "timeSeries": [ { "metric": {
We should add a CI check to make sure fixtures are updated before merging so irrelevant changes don't get added later
The text was updated successfully, but these errors were encountered:
fixed by #460
Sorry, something went wrong.
damemi
No branches or pull requests
#452 introduced a new diff when recording new fixtures:
We should add a CI check to make sure fixtures are updated before merging so irrelevant changes don't get added later
The text was updated successfully, but these errors were encountered: