-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the function snippet syntax to ES6 standards. #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 13 13
Lines 458 458
=======================================
Hits 445 445
Misses 13 13
Continue to review full report at Codecov.
|
LGTM. |
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.2...v2.4.3) (2021-01-27) ### Bug Fixes * handle parameters to image.create() ([#541](https://www.github.com/googleapis/nodejs-compute/issues/541)) ([3b3a7dd](https://www.github.com/googleapis/nodejs-compute/commit/3b3a7dd81790b788d5d53947e2948df55b702c93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 14, 2022
grayside
pushed a commit
that referenced
this pull request
Nov 16, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Shabir Mohamed Abdul Samadh <[email protected]>
grayside
pushed a commit
that referenced
this pull request
Nov 16, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Shabir Mohamed Abdul Samadh <[email protected]>
grayside
pushed a commit
that referenced
this pull request
Nov 16, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Shabir Mohamed Abdul Samadh <[email protected]>
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Shabir Mohamed Abdul Samadh <[email protected]>
grayside
pushed a commit
that referenced
this pull request
Nov 17, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Shabir Mohamed Abdul Samadh <[email protected]>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 17, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Shabir Mohamed Abdul Samadh <[email protected]>
kweinmeister
pushed a commit
that referenced
this pull request
Nov 18, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.7](https://www.github.com/googleapis/nodejs-text-to-speech/compare/v3.2.6...v3.2.7) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#541](https://www.github.com/googleapis/nodejs-text-to-speech/issues/541)) ([0c93b5b](https://www.github.com/googleapis/nodejs-text-to-speech/commit/0c93b5bd89bd983c1a9d658d22179b8732b533ed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.2...v2.4.3) (2021-01-27) ### Bug Fixes * handle parameters to image.create() ([#541](https://www.github.com/googleapis/nodejs-compute/issues/541)) ([3b3a7dd](https://www.github.com/googleapis/nodejs-compute/commit/3b3a7dd81790b788d5d53947e2948df55b702c93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.2...v2.4.3) (2021-01-27) ### Bug Fixes * handle parameters to image.create() ([#541](https://www.github.com/googleapis/nodejs-compute/issues/541)) ([3b3a7dd](https://www.github.com/googleapis/nodejs-compute/commit/3b3a7dd81790b788d5d53947e2948df55b702c93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the email thread.
@ace-n