Skip to content

Commit

Permalink
Remove skip_files from app.yaml files, as it's no longer needed.
Browse files Browse the repository at this point in the history 
Closes #106
  • Loading branch information
@jmdobry
jmdobry committed May 25, 2016
1 parent 8b19db4 commit e783b2f
Show file tree
Hide file tree
Showing 32 changed files with 0 additions and 97 deletions.
3 changes: 0 additions & 3 deletions appengine/analytics/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,4 @@ vm: true
env_variables:
GA_TRACKING_ID: <your-tracking-id>
# [END env]

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/bower/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/cloudsql/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,4 @@ env_variables:
MYSQL_PASSWORD: <your-cloudsql-password>
MYSQL_DATABASE: <your-cloudsql-database>
# [END env]

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/datastore/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,4 @@ vm: true
env_variables:
GCLOUD_PROJECT: <your-project-id>
# [END env_variables]

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/disk/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,5 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]

3 changes: 0 additions & 3 deletions appengine/endpoints/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$

beta_settings:
# Enable Google Cloud Endpoints API management.
use_endpoints_api_management: true
Expand Down
3 changes: 0 additions & 3 deletions appengine/errorreporting/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/express-memcached-session/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,4 @@ runtime: nodejs
vm: true
env_variables:
MEMCACHE_URL: localhost:11211

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/express/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/geddy/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/grunt/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/hapi/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/hello-world/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/koa/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/kraken/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/logging/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/loopback/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/mailgun/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,4 @@ runtime: nodejs
vm: true
env_variables:
MAILGUN_API_KEY: <your-mailgun-api-key>

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/mailjet/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,4 @@ vm: true
env_variables:
MJ_APIKEY_PUBLIC: <your-mj-apikey-public>
MJ_APIKEY_PRIVATE: <your-mj-apikey-private>

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/memcached/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,4 @@ vm: true
beta_settings:
use_memcache_proxy: true
# [END config]

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/mongodb/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
4 changes: 0 additions & 4 deletions appengine/parse-server/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
# Don't deploy node_modules folder
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/pubsub/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,4 @@ env_variables:
# application. It can be any sufficiently random string.
PUBSUB_VERIFICATION_TOKEN: <your-verification-token>
# [END env]

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/redis/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/restify/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/sails/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/sendgrid/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,4 @@ env_variables:
SENDGRID_API_KEY: <your-sendgrid-api-key>
SENDGRID_SENDER: <your-sendgrid-sender>
# [END env_variables]

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/static-files/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/storage/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,4 @@ env_variables:
GCLOUD_PROJECT: <your-project-id>
GCLOUD_STORAGE_BUCKET: <your-bucket-name>
# [END env]

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/twilio/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,4 @@ env_variables:
TWILIO_AUTH_TOKEN: <your-auth-token>
TWILIO_NUMBER: <your-twilio-number>
# [END env_variables]

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/webpack/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
# [START app_yaml]
runtime: nodejs
vm: true

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]
3 changes: 0 additions & 3 deletions appengine/websockets/app.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,4 @@ network:
- 65080
instance_tag: websocket
# [END network]

skip_files:
- ^(.*/)?.*/node_modules/.*$
# [END app_yaml]

6 comments on commit e783b2f

@motdotla
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmdobry Does app engine know to ignore them by default now?

@jmdobry
Copy link
Member Author

@jmdobry jmdobry commented on e783b2f Jun 3, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkHerhold
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmdobry what do we do if we need to include private npm modules in the App Engine docker build (gcloud preview app deploy)?

@jmdobry
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. How do the private npm modules get installed normally?

cc @JustinBeckwith thoughts?

@MarkHerhold
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmdobry I asked and eventually answered this on SO: http://stackoverflow.com/questions/37780523/private-node-modules-on-google-app-engine

I basically created a custom container and added my npm token via .npmrc

@jmdobry
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Please sign in to comment.