Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cf gen two #50

Merged
merged 13 commits into from
Oct 10, 2023
Merged

Cf gen two #50

merged 13 commits into from
Oct 10, 2023

Conversation

kingman
Copy link
Collaborator

@kingman kingman commented Oct 6, 2023

Description

  • refactored the activation function to Cloud Functions 2nd Gen make the solution ready for most cloud regions
  • Set ingress_setting to only allow internal calls on activation function

How has this been tested?

integration tested

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

Pipeline run links:

@kingman kingman requested a review from chmstimoteo October 6, 2023 17:37
chmstimoteo
chmstimoteo approved these changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@chmstimoteo chmstimoteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chmstimoteo chmstimoteo self-requested a review October 10, 2023 17:07
chmstimoteo
chmstimoteo approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@chmstimoteo chmstimoteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kingman kingman merged commit a506012 into GoogleCloudPlatform:main Oct 10, 2023
1 of 2 checks passed
@kingman kingman deleted the cf-gen-two branch October 10, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmstimoteo chmstimoteo chmstimoteo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingman @chmstimoteo