From 1ee0dfd89d9f86187802554a20c706c59461f571 Mon Sep 17 00:00:00 2001 From: Dana Hoffman Date: Fri, 9 Aug 2019 08:58:25 -0700 Subject: [PATCH 1/2] have the magician tag a reviewer for external PRs --- .ci/magic-modules/welcome-contributor.sh | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.ci/magic-modules/welcome-contributor.sh b/.ci/magic-modules/welcome-contributor.sh index 65d44f8913d2..934a36472db4 100755 --- a/.ci/magic-modules/welcome-contributor.sh +++ b/.ci/magic-modules/welcome-contributor.sh @@ -2,14 +2,20 @@ set -x +ASSIGNEE=$(shuf -n 1 <(printf "danawillow\nrambleraptor\nemilymye\nrileykarson\nSirGitsalot\nslevenick\ntysen")) + cat > comment/pr_comment << EOF Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. -EOF -shuf -n 1 <(printf "danawillow\nrambleraptor\nchrisst\nrileykarson\nSirGitsalot\nslevenick\ntysen") > comment/assignee +$ASSIGNEE, please review this PR or find an appropriate assignee. +EOF +# Something is preventing the magician from actually assigning the PRs. +# Leave this part in so we know what was supposed to happen, but the real +# logic is above. +echo $ASSIGNEE > comment/assignee cat comment/assignee From 5764c46fd2462defa15370c086fa458460a4545e Mon Sep 17 00:00:00 2001 From: Dana Hoffman Date: Fri, 9 Aug 2019 14:48:55 -0700 Subject: [PATCH 2/2] actually tag --- .ci/magic-modules/welcome-contributor.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/magic-modules/welcome-contributor.sh b/.ci/magic-modules/welcome-contributor.sh index 934a36472db4..7d05607070e6 100755 --- a/.ci/magic-modules/welcome-contributor.sh +++ b/.ci/magic-modules/welcome-contributor.sh @@ -11,7 +11,7 @@ I have detected that you are a community contributor, so your PR will be assigne Thanks for your contribution! A human will be with you soon. -$ASSIGNEE, please review this PR or find an appropriate assignee. +@$ASSIGNEE, please review this PR or find an appropriate assignee. EOF # Something is preventing the magician from actually assigning the PRs.