-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove retry in read as retry for create/update is already handled in respective methods #12028
fix: remove retry in read as retry for create/update is already handled in respective methods #12028
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
What bug(s) is this addressing / what's the context? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 109 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 109 Click here to see the affected service packages
🟢 All tests passed! View the build log |
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Hi @gurusai-voleti, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 109 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering public documentation of cloud storage consistency:https://cloud.google.com/storage/docs/consistency#strongly_consistent_operations, Bucket Listing is strongly consistent operation so we don't need retry logic for bucket read operation.
…ed in respective methods (GoogleCloudPlatform#12028)
…ed in respective methods (GoogleCloudPlatform#12028)
…ed in respective methods (GoogleCloudPlatform#12028)
remove retry in read as retry for create/update is already handled in respective methods
Fixes: hashicorp/terraform-provider-google#13464
Release Note Template for Downstream PRs (will be copied)