add auto_accept_projects in ncc group

[prauc]

This PR adds google_network_connectivity_group to define auto_accept_projects in NCC.

https://cloud.google.com/network-connectivity/docs/reference/networkconnectivity/rest/v1/projects.locations.global.hubs.groups

Tests for networkconnectivity were already successfully executed locally

Release Note Template for Downstream PRs (will be copied)

networkconnectivity: added support for `google_network_connectivity_group`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1137 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1137 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_group (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_group" "primary" {
  description = # value needed
  labels      = # value needed
}

[modular-magician]

Tests analytics

Total tests: 26
Passed tests: 23
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

• networkconnectivity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkConnectivityGroup_BasicGroup
• TestAccNetworkConnectivityGroup_networkConnectivityGroupBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkConnectivityGroup_networkConnectivityGroupBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkConnectivityGroup_BasicGroup[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[c2thorn]

Hi @prauc

The Magic Modules repository has recently migrated from Ruby to Go. You can view more details about this in our announcement here: hashicorp/terraform-provider-google#19583 (or go/mm-migration-announcement if you are a Googler)

This open pull request has likely become incompatible due to most YAML and .erb files converting to Go-compatible files.

Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.

In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event additional changes are needed.

You also have the option to update the pull request yourself. You can view updated documentation related to the migration changes.

We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me or your reviewer know if you have any further questions!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1137 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1137 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_group (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_group" "primary" {
  description = # value needed
  labels      = # value needed
}

[modular-magician]

Tests analytics

Total tests: 26
Passed tests: 24
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• networkconnectivity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkConnectivityGroup_BasicGroup

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkConnectivityGroup_BasicGroup[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[prauc]

sorry, I somehow messed this up..
I created a new, fresh PR, not with 5k file changes ..
see #11828