Making network field optional in Backupdr MS

[niharika-98]

Release Note Template for Downstream PRs (will be copied)

backupdr: make `network` field optional in `google_backup_dr_management_server` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 2 files changed, 19 insertions(+), 19 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_backup_dr_management_server (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_backup_dr_management_server" "primary" {
  networks {
    network = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 1
Passed tests: 1
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• backupdr

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[roaks3]

Apologies if there's a limitation I've missed, but could you add a test (or probably better to modify an existing test) to not include these fields? This will help verify that they are in fact not required.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 2 files changed, 19 insertions(+), 45 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_backup_dr_management_server (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_backup_dr_management_server" "primary" {
  networks {
    network = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• backupdr

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBackupDRBackupVault_fullUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 3 files changed, 19 insertions(+), 49 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_backup_dr_management_server (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_backup_dr_management_server" "primary" {
  networks {
    network = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• backupdr

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleBackupDRManagementServer_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGoogleBackupDRManagementServer_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 3 files changed, 19 insertions(+), 49 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_backup_dr_management_server (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_backup_dr_management_server" "primary" {
  networks {
    network = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• backupdr

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleBackupDRManagementServer_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGoogleBackupDRManagementServer_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 3 files changed, 19 insertions(+), 49 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_backup_dr_management_server (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_backup_dr_management_server" "primary" {
  networks {
    network = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• backupdr

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleBackupDRManagementServer_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGoogleBackupDRManagementServer_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[roaks3]

It looks like there is still a test failure, potentially for another test. But to be clear, I don't think every existing test should be changed (unless you are doing that for another reason, like performance?). I expected there to be one test with this field removed, to prove it is not required.

[github-actions]

@niharika-98, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[c2thorn]

@niharika-98

Tomorrow, the Magic Modules repository is scheduled to undergo a language migration from Ruby to Go. You can view more details about this in our announcement here: hashicorp/terraform-provider-google#19583 (or go/mm-migration-announcement if you are a Googler)

This open pull request may become incompatible due to most YAML and .erb files converting to Go-compatible files.

However, the changes seem minor enough that editing the converted files should not be too difficult. The main difficulty will be rebasing after the migration, but I suggest simply opening a new pull request. That should be easier overall.

Let us know if you have any questions or issues.

[github-actions]

@niharika-98, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 255 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 255 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 54
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• networkservices

🟢 All tests passed!

View the build log