Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata Service: Incomplete removal of deployment "deployment" #182

Closed
muthurajr opened this issue Dec 10, 2020 · 2 comments · Fixed by kubeflow/manifests#1718
Closed

Metadata Service: Incomplete removal of deployment "deployment" #182

muthurajr opened this issue Dec 10, 2020 · 2 comments · Fixed by kubeflow/manifests#1718
Assignees
@Bobgy

Comments

@muthurajr
Copy link

In the apps file https://github.com/kubeflow/manifests/blob/v1.2.0/metadata/base/metadata-deployment.yaml, deployment "deployment" is removed as part of 1.2.0 release but not removed in the patch https://github.com/kubeflow/manifests/blob/v1.2.0/metadata/overlays/google-cloudsql/metadata-deployment.yaml

This is causing metadata installation to fail when using google-cloudsql.
@PatrickXYS
Copy link

/cc @Bobgy

@Bobgy Bobgy transferred this issue from kubeflow/manifests Dec 24, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Dec 24, 2020

Thanks for the report! I'll fix this

@Bobgy Bobgy mentioned this issue Dec 24, 2020
Closed
@Bobgy Bobgy mentioned this issue Jan 15, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bobgy Bobgy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: delete outdated metadata google cloudsql overlay Bobgy/manifests
3 participants
@Bobgy @PatrickXYS @muthurajr