Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample YAML for DNSRecordSet "DNS A Record Set" uses deprecated field #3287

Open
3 tasks done
rrrix opened this issue Dec 3, 2024 · 0 comments
Open
3 tasks done

Sample YAML for DNSRecordSet "DNS A Record Set" uses deprecated field #3287

rrrix opened this issue Dec 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rrrix
Copy link

rrrix commented Dec 3, 2024

Checklist

Bug Description

The DNS A Record Set Sample YAML example for DNSRecordSet uses the deprecated spec.rrdatas field, resulting in a linter warning.

Also, it's not clear if one can (should?) use spec.rrdatasRefs[].external for the same purpose.

spec.rrdatasRefs[].external has the following description:

Allowed value: The address field of a ComputeAddress resource.

What if we want to create a DNS record for an IP that isn't a ComputeAddress (like a non-GCP IP address)?

Additional Diagnostic Information

Key 'rrdatas' is deprecated

DEPRECATED. Although this field is still available, there is limited support. We recommend that you use spec. rrdatasRefs instead.

Kubernetes Cluster Version

v1.30.5-gke.1014003

Config Connector Version

1.124.0

Config Connector Mode

namespaced mode (default)

Log Output

No response

Steps to reproduce the issue

Use the DNSRecordSet Sample YAML with an IDE or linting tool that checks for deprecated fields, for example:

YAML snippets

# From https://cloud.google.com/config-connector/docs/reference/resource-docs/dns/dnsrecordset#dns_a_record_set
#
# Copyright 2020 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

apiVersion: dns.cnrm.cloud.google.com/v1beta1
kind: DNSRecordSet
metadata:
  name: dnsrecordset-sample-a
spec:
  name: "www.example.com."
  type: "A"
  ttl: 300
  managedZoneRef:
    name: dnsrecordset-dep-a
  rrdatas:
  - "8.8.8.8"
---
apiVersion: dns.cnrm.cloud.google.com/v1beta1
kind: DNSManagedZone
metadata:
  name: dnsrecordset-dep-a
spec:
  dnsName: "example.com."
@rrrix rrrix added the bug Something isn't working label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant