From d549a57e53bf18f84377095631da792c9fcd4ee4 Mon Sep 17 00:00:00 2001 From: Jerjou Cheng Date: Fri, 3 Mar 2017 21:22:47 -0800 Subject: [PATCH 1/2] Disable some shellchecks. --- jenkins.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/jenkins.sh b/jenkins.sh index c4200552a72..aee7ecdc63c 100755 --- a/jenkins.sh +++ b/jenkins.sh @@ -19,6 +19,7 @@ shopt -s globstar app_version="" +# shellcheck disable=SC2120 delete_app_version() { if [ -n "${app_version}" ] || [ $# -gt 0 ]; then yes | gcloud --project="${GOOGLE_PROJECT_ID}" \ @@ -29,7 +30,7 @@ handle_error() { errcode=$? # Remember the error code so we can exit with it after cleanup # Clean up - delete_app_version + delete_app_version # shellcheck disable=SC2119 exit ${errcode} } From 58f630b655170380884bbbccfc59352125c540f5 Mon Sep 17 00:00:00 2001 From: Jerjou Cheng Date: Fri, 3 Mar 2017 21:22:47 -0800 Subject: [PATCH 2/2] Disable some shellchecks. --- jenkins.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jenkins.sh b/jenkins.sh index aee7ecdc63c..aed99618c40 100755 --- a/jenkins.sh +++ b/jenkins.sh @@ -40,7 +40,7 @@ trap handle_error ERR shellcheck ./**/*.sh # Find all jenkins.sh's and run them. -find . -mindepth 2 -maxdepth 5 -name jenkins.sh -type f | while read path; do +find . -mindepth 2 -maxdepth 5 -name jenkins.sh -type f | while read -r path; do dir="${path%/jenkins.sh}" app_version="jenkins-${dir//[^a-z]/}" (