Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videointelligence: Add v1p2beta1 to synth.py #6004

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Conversation

danoscarmike
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2018
@tseaver tseaver added api: videointelligence Issues related to the Video Intelligence API API. codegen labels Sep 17, 2018
@tseaver tseaver changed the title Add v1p2beta1 to synth.py Videointelligence: Add v1p2beta1 to synth.py Sep 17, 2018
@tseaver tseaver force-pushed the danoscarmike-patch-2 branch from e8451f7 to 705387c Compare September 17, 2018 21:41
@tseaver
Copy link
Contributor

tseaver commented Sep 17, 2018

@danoscarmike I rebased to clear up CI. Don't we need to re-run synth.py to pick up the new tree?

@danoscarmike
Copy link
Contributor Author

@tseaver, thanks and yes, but wanted to get someone's eyes on it first (after my botched attempt to help on Redis 👎)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 17, 2018
@danoscarmike
Copy link
Contributor Author

LGTM - thanks @tseaver

@theacodes to flip CLA label to yes.

@theacodes theacodes added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 17, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@tseaver tseaver force-pushed the danoscarmike-patch-2 branch from 7a57987 to 0ef1549 Compare September 18, 2018 02:46
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 18, 2018
@tseaver tseaver force-pushed the danoscarmike-patch-2 branch from 0ef1549 to 0b886e4 Compare September 18, 2018 02:55
@tseaver
Copy link
Contributor

tseaver commented Sep 18, 2018

After rebasing to fix up master docs builds, Sphinx blows now:

sphinx.errors.SphinxWarning: /home/tseaver/projects/agendaless/Google/src/google-cloud-python/docs/videointelligence/gapic/v1p2beta1/api.rst:document isn't included in any toctree

We need to land PR #6002, and then fix up docs/index.rst to include the v1p2beta1 API docs.

@danoscarmike danoscarmike added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 18, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2018
@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 18, 2018
@tseaver tseaver merged commit e66db55 into master Sep 18, 2018
@tseaver tseaver deleted the danoscarmike-patch-2 branch September 18, 2018 20:21
@danoscarmike
Copy link
Contributor Author

Thanks @tseaver!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: videointelligence Issues related to the Video Intelligence API API. cla: no This human has *not* signed the Contributor License Agreement. codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants