Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span_id to LogEntry #5885

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Add span_id to LogEntry #5885

merged 2 commits into from
Sep 4, 2018

Conversation

salrashid123
Copy link
Contributor

Add span_id to LogEntry

Note trace should get specified if span_id is set. The logging API does not currently return an error and while the final displayed log line does have a span_id, its not too useful. Instead of client-side validation, CloudLogging would return exception later (i'll file internal FR for that)

ref:

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 4, 2018
@salrashid123
Copy link
Contributor Author

am i missing something in the cover tests? i didn't really do anything there to account for that coverage failure

Name                                                            Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------------------------------
google/cloud/logging/logger.py                                    124      1     58      1    99%   593, 584->593

@tseaver
Copy link
Contributor

tseaver commented Sep 4, 2018

@salrashid123 I'm puzzled, too: that branch / line should be covered by test_commit_w_invalid_entry_type.

@salrashid123
Copy link
Contributor Author

@tseaver Is there a directive you can invoke to rerun the checks (i.e, /oktotest)?

btw, i tried running cover locally but that looks for python3.7

$ nox -f logging/nox.py -s cover
nox > Running session cover
nox > /usr/bin/python -m virtualenv /home/srashid/workspace/github/google-cloud-python/.nox/cover -p python3.6
nox > Command /usr/bin/python -m virtualenv /home/srashid/workspace/github/google-cloud-python/.nox/cover -p python3.6 failed with exit code 3:
The path python3.6 (from --python=python3.6) does not exist
nox > Session cover failed.

i tried changing the session.interpreter= value to python27 in logging/nox.py but that gives other errors

@tseaver tseaver merged commit 4c7adde into googleapis:master Sep 4, 2018
@tseaver
Copy link
Contributor

tseaver commented Sep 4, 2018

Nice catch!

@salrashid123 salrashid123 deleted the add-logging-span-option branch September 5, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants