Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nox: use inplace installs #5865

Merged
merged 20 commits into from
Aug 30, 2018
Merged

Nox: use inplace installs #5865

merged 20 commits into from
Aug 30, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 29, 2018

The overall intent here is to use in-place installs for all local packages, to ease debugging using the "mainline" versions of the packages.

@tseaver tseaver added api: datastore Issues related to the Datastore API. api: storage Issues related to the Cloud Storage API. testing api: bigquery Issues related to the BigQuery API. api: dns Issues related to the Cloud DNS API. api: pubsub Issues related to the Pub/Sub API. api: core api: bigtable Issues related to the Bigtable API. api: cloudresourcemanager Issues related to the Resource Manager API. api: logging Issues related to the Cloud Logging API. api: monitoring Issues related to the Cloud Monitoring API. api: translation Issues related to the Cloud Translation API API. api: spanner Issues related to the Spanner API. api: clouderrorreporting Issues related to the Error Reporting API. api: language Issues related to the Cloud Natural Language API API. api: cloudtrace Issues related to the Cloud Trace API. api: firestore Issues related to the Firestore API. api: container Issues related to the Kubernetes Engine API API. api: redis Issues related to the Memorystore for Redis API. labels Aug 29, 2018
@tseaver tseaver requested a review from crwilcox August 29, 2018 22:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2018
tseaver added 14 commits August 29, 2018 18:01
@tseaver
dns: install local packages inplace under nox.
cf27394
@tseaver
error_reporting: install local packages inplace under nox.
eb80bb5
@tseaver
firestore: install local packages inplace under nox.
3becd69
@tseaver
language: install local packages inplace under nox.
1438d0a
@tseaver
logging: install local packages inplace under nox.
4e6fe76
@tseaver
pubsub: install local packages inplace under nox.
b83aad5
@tseaver
redis: install local packages inplace under nox.
b682f3c
@tseaver
resource_manager: install local packages inplace under nox.
157c337
@tseaver
spanner: install local packages inplace under nox.
ec7a953
@tseaver
storage: install local packages inplace under nox.
0bb0653
@tseaver
trace: install local packages inplace under nox.
b1c0224
@tseaver
translate: install local packages inplace under nox.
7380975
@tseaver
websecurityscanner: install local packages inplace under nox.
d8d5f66
@tseaver
Whitespace fix.
8bfefdf
@tseaver tseaver force-pushed the nox-use-inplace-installs branch from 35c4591 to 8bfefdf Compare August 29, 2018 22:01
tswast
tswast reviewed Aug 29, 2018
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can we also do inplace installs for the documentation builds? I've found it counter-intuitive that it has to reinstall everything to get docs updates (I can't reuse environments to rebuild the docs)

@tseaver
Copy link
Contributor Author

tseaver commented Aug 29, 2018

@tswast

Can we also do inplace installs for the documentation builds?

I borrowed Guido's time machine: see #5775.

@tseaver tseaver mentioned this pull request Aug 30, 2018
Closed
@tseaver tseaver merged commit 2dd7795 into master Aug 30, 2018
@tseaver tseaver deleted the nox-use-inplace-installs branch August 30, 2018 15:50
@tseaver tseaver mentioned this pull request Sep 12, 2018
Merged
parthea pushed a commit that referenced this pull request Jun 4, 2023
@tseaver
Nox: use inplace installs (#5865)
d6c5ab6
parthea pushed a commit that referenced this pull request Jun 4, 2023
@tseaver
Nox: use inplace installs (#5865)
e6e76ba
parthea pushed a commit that referenced this pull request Jun 4, 2023
@tseaver
Nox: use inplace installs (#5865)
324963a
parthea pushed a commit that referenced this pull request Jul 6, 2023
@tseaver
Nox: use inplace installs (#5865)
b81db21
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Nox: use inplace installs (#5865)
026f2b8
parthea pushed a commit that referenced this pull request Oct 21, 2023
@tseaver
Nox: use inplace installs (#5865)
56325c5
parthea pushed a commit that referenced this pull request Oct 22, 2023
@tseaver
Nox: use inplace installs (#5865)
7bc5c72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@alixhami alixhami Awaiting requested review from alixhami

@dhermes dhermes Awaiting requested review from dhermes

@liyanhui1228 liyanhui1228 Awaiting requested review from liyanhui1228

@theacodes theacodes Awaiting requested review from theacodes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. api: bigtable Issues related to the Bigtable API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudresourcemanager Issues related to the Resource Manager API. api: cloudtrace Issues related to the Cloud Trace API. api: container Issues related to the Kubernetes Engine API API. api: core api: datastore Issues related to the Datastore API. api: dns Issues related to the Cloud DNS API. api: firestore Issues related to the Firestore API. api: language Issues related to the Cloud Natural Language API API. api: logging Issues related to the Cloud Logging API. api: monitoring Issues related to the Cloud Monitoring API. api: pubsub Issues related to the Pub/Sub API. api: redis Issues related to the Memorystore for Redis API. api: spanner Issues related to the Spanner API. api: storage Issues related to the Cloud Storage API. api: translation Issues related to the Cloud Translation API API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @tswast @googlebot