Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: docs for Row.keys, items, values, and get functions. #4413

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 17, 2017

Also updates behavior to return generators/iterators, more in line with dict.

Follow-up to #4393.

Updates system tests for new generators. Second try at #4410.

- Refactors items, keys to return iterators.
- Copies values to prevent mutating the original row object.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2017
@tswast
Copy link
Contributor Author

tswast commented Nov 17, 2017

Also pushed to pr-4413-bq-row branch. System tests running: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/4293

@tswast tswast requested a review from dhermes November 17, 2017 19:25
@dhermes
Copy link
Contributor

dhermes commented Nov 17, 2017

@tswast LGTM but ISTM you might just be happier putting .values() back the way it was?

@jonparrott WDYT?

@tswast
Copy link
Contributor Author

tswast commented Nov 20, 2017

Dropped the change to a generator for values().

@dhermes dhermes added the api: bigquery Issues related to the BigQuery API. label Nov 22, 2017
@tswast tswast merged commit b24ce6e into googleapis:master Nov 22, 2017
@tswast tswast deleted the bq-row-docs branch November 22, 2017 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants