Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate insertId if not provided. #2739

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

stephenplusplus
Copy link
Contributor

Fixes #1041

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2e44af4 on stephenplusplus:spp--1041 into f10f61f on GoogleCloudPlatform:master.

@callmehiphop
Copy link
Contributor

@tswast based on some dialog within the attached issue, it seems like a uuid per row might not be the way to go. Would you mind taking a peak at this?

@tswast
Copy link
Contributor

tswast commented Nov 13, 2017

UUID-per-row is the way to go (if the user does not provide one).

After some discussion with the BigQuery team, we determined that a row ID should always be included in the request. If not present, create a unique ID for the row through a suitably random source.

The reason behind this is so that the API request can safely be retried by the client library.

@callmehiphop
Copy link
Contributor

Awesome, thanks for the feedback!

@stephenplusplus stephenplusplus merged commit 25af76e into googleapis:master Nov 13, 2017
@stephenplusplus stephenplusplus added api: bigquery Issues related to the BigQuery API. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants