-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add execution id support #592
feat: add execution id support #592
Conversation
I think you need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create integration test for this or would it be too complicated? similar to test/integration/http.ts . Not sure if we could redirect stdout to some sort of pipe and be able inspect the contents or make test function dump stdout on res.body. Let me know what you think.
I haven't figured out how to do that yet. All the ways I found are overriding console.log or process.stdout.write, which is the function we monkey patch in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please wait on nifflets's approval before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Lets drop the global getExecutionId
function from the API for now.
ea14efc
Add execution id support.
When set
LOG_EXECUTION_ID=True
in environment variables or set--log-execution-id
, execution id will be added to log along with trace and span id.Nodejs version 13.0.0 is required for feature above.