fix: make renovatebot's ignorePath and grouping of non-major updates work correctly #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenneth-rosario
requested review from
hdp617 and
anniefu
and removed request for
hdp617
anniefu
approved these changes
Jan 9, 2023
kenneth-rosario
force-pushed
the
fix_renovatebot_config
branch
from
4ce2218 to
66a663c
Compare
|
(side note, probably this should have been a non-triggering type like chore or ci / build vs. fix)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The renovate configs currently in use is not correctly ignoring the docs and experimental folders, and seems to not group non major updates together.
ignorePathswas not working due to a current issue with renovate itself whereignorePathsis being overwrited by thecoinfig:basedefaults. The suggested fix is to useglobalExtendsproperty. Discussion used: ignorePaths overriden renovatebot/renovate#14793group:allNonMajorextension which ended up grouping non-major versions correctly.Tested by forking repo, changing versions manually, and then running a locally cloned renovate bot against my fork with the updated renovate config file.
Example of how non major grouping would look like:
