Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include note about socket length when Unix socket fails to bind #970

Open
enocom opened this issue Oct 6, 2021 · 1 comment
Open

Include note about socket length when Unix socket fails to bind #970

enocom opened this issue Oct 6, 2021 · 1 comment
Assignees
@jackwotherspoon
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Oct 6, 2021

This is a follow-on to #747 and a slight alternative to #960. When a Unix socket returns bind: invalid argument, we should include a note in the error message to check maximum socket length as a possible cause.
@enocom enocom added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 6, 2021
@enocom enocom assigned enocom and unassigned shubha-rajan Oct 9, 2021
@m4r1k
Copy link

m4r1k commented Sep 1, 2022 •
edited
Loading

Strict double-checking around the length must be enforced.
Follows the official Linux code reference and the reason why can't be more than 108 chars.
https://github.com/torvalds/linux/blob/master/net/unix/af_unix.c#L291-L302

@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 1, 2022
@enocom enocom removed their assignment Oct 13, 2022
@enocom enocom assigned jackwotherspoon and unassigned enocom May 1, 2024
@eldad eldad mentioned this issue Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@enocom @m4r1k @shubha-rajan @kurtisvg @jackwotherspoon