Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to a public access to cloudsql-instance #754

Conversation

alefmreis
Copy link
Contributor

@alefmreis alefmreis commented Jul 21, 2022

  • Add support to a public access to cloudsql-instance setting up ipv4_enabled parameter

@google-cla
Copy link

google-cla bot commented Jul 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alefmreis alefmreis marked this pull request as draft July 25, 2022 14:57
@alefmreis alefmreis marked this pull request as ready for review July 25, 2022 14:59
…m:alefmreis/cloud-foundation-fabric into alefmreis/support-cloud-sql-public-access
@alefmreis alefmreis closed this Jul 25, 2022
@alefmreis alefmreis reopened this Jul 25, 2022
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left you a small comment below.

modules/cloudsql-instance/variables.tf Outdated Show resolved Hide resolved
@juliocc juliocc added enhancement New feature or request on:modules labels Aug 8, 2022
@juliocc
Copy link
Collaborator

juliocc commented Aug 9, 2022

Your test is failing now :(

…m:alefmreis/cloud-foundation-fabric into alefmreis/support-cloud-sql-public-access
@ludoo ludoo merged commit 97104c0 into GoogleCloudPlatform:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants