Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also depend on shared vpc host in project module #752

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Also depend on shared vpc host in project module #752

merged 2 commits into from
Jul 21, 2022

Conversation

apichick
Copy link
Collaborator

…_host to project_id output and modified tests

@apichick
Added dependency on google_compute_shared_vpc_host_project.shared_vpc…
f153ab4 
…_host to project_id output and modified tests
ludoo
ludoo approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@apichick apichick merged commit 91251d8 into GoogleCloudPlatform:master Jul 21, 2022
@apichick apichick deleted the shared-vpc-host-dependency branch July 21, 2022 12:51
@apichick apichick restored the shared-vpc-host-dependency branch July 21, 2022 12:53
@apichick apichick deleted the shared-vpc-host-dependency branch July 21, 2022 12:53
@ludoo ludoo changed the title Added dependency on google_compute_shared_vpc_host_project.shared_vpc… Also depend on shared vpc host in project module Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apichick @ludoo