Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Cloud Run VPC Connector annotations to template metadata (#735) #737

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

sethmoon
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Jul 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo
Copy link
Collaborator

ludoo commented Jul 13, 2022

Seth, could you go through the CLA steps?

Fixes #735

Copy link
Contributor Author

@sethmoon sethmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a new local variable for vpc metadata that will be applied to the cloud run template

@sethmoon
Copy link
Contributor Author

@ludoo CLA signed

@ludoo
Copy link
Collaborator

ludoo commented Jul 13, 2022

Thanks for this!

@ludoo ludoo merged commit a8677ed into GoogleCloudPlatform:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants