Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPConnector mode: Servlet session datastore.put() call to save the session is flaky #279

Open
ludoch opened this issue Sep 27, 2024 · 1 comment · May be fixed by #278
Open

HTTPConnector mode: Servlet session datastore.put() call to save the session is flaky #279

ludoch opened this issue Sep 27, 2024 · 1 comment · May be fixed by #278
Assignees
@ludoch

Comments

@ludoch
Copy link
Collaborator

ludoch commented Sep 27, 2024

Sometimes, when servlet sessions are enabled, the app gets an error in the like:

com.google.apphosting.api.ApiProxy$CancelledException: The API call datastore_v3.Put() was explicitly cancelled. at com.google.apphosting.utils.runtime.ApiProxyUtils.convertApiError(ApiProxyUtils.java:75) at com.google.apphosting.utils.runtime.ApiProxyUtils.getApiError(ApiProxyUtils.java:202) at com.google.apphosting.runtime.ApiProxyImpl$AsyncApiFuture.success(ApiProxyImpl.java:691) at com.google.apphosting.runtime.ApiProxyImpl$AsyncApiFuture.success(ApiProxyImpl.java:588) at com.google.apphosting.runtime.http.HttpApiHostClient.receivedResponse(HttpApiHostClient.java:296) at com.google.apphosting.runtime.http.JettyHttpApiHostClient$Listener.onComplete(JettyHttpApiHostClient.java:206) at

It seems related to a possible flake in the API server backend, having a race condition between the close statement of the HTTP request and the API request, and when the API is really called, the API ticket is null, and it should not be null.
@ludoch ludoch self-assigned this Sep 27, 2024
@ludoch
Copy link
Collaborator Author

ludoch commented Sep 27, 2024

Possible code change on java side #278 does not seems enough.
Looking at C++ server side now.

@ludoch ludoch linked a pull request Sep 27, 2024 that will close this issue
Open
@ludoch ludoch linked a pull request Sep 27, 2024 that will close this issue
Fixes to completion of RequestManager in HttpMode #278
Open
copybara-service bot pushed a commit that referenced this issue Oct 2, 2024
@ludoch @gae-java-bot
Add a system property ("appengine.ignore.cancelerror") to ignore CANC…
78bbabe 
…ELLED errors from the API proxy. See #279

PiperOrigin-RevId: 681616924
Change-Id: Icc1cebe0c506e66bbde5a3b83b2ad5004c82d11f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ludoch ludoch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to completion of RequestManager in HttpMode GoogleCloudPlatform/appengine-java-standard
1 participant
@ludoch