Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): fix anthos-bm-gcp-terraform (Golang) unit tests #697

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Aug 30, 2024

  • install the Go version from the go.mod for any Golang unit tests (instead of depending on the gh runner's version)
  • update the anthos-bm-gcp-terraform tests
    • for recent variable changes
    • generic Go bast practices
    • go mod tidy
  • a few similar/minor doc fixes for anthos-bm-apigee

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 30, 2024
@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@apeabody apeabody changed the title chore(C): fix main_test location chore(CI): fix main_test Aug 30, 2024
@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 30, 2024

/gcbrun

@apeabody apeabody changed the title chore(CI): fix main_test chore(CI): fix anthos-bm-gcp-terraform (Golang) unit tests Aug 30, 2024
@apeabody apeabody marked this pull request as ready for review August 30, 2024 23:03
@apeabody apeabody requested review from yoshi-approver and a team as code owners August 30, 2024 23:03
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeabody apeabody merged commit c909f72 into main Sep 3, 2024
18 checks passed
@apeabody apeabody deleted the apeabody-patch-1 branch September 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants