-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add terraform samples for GKE Attached clusters. #667
feat: Add terraform samples for GKE Attached clusters. #667
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Add samples demonstrating use of GKE attached clusters with both AKS and EKS. The samples: 1. create a cluster 2. prepare the cluster for attach 3. attach the cluster as a single Terraform apply step which has been problematic for users.
77ecb24
to
d6087e6
Compare
/gcbrun |
/gcbrun |
@bharathkkb the CI tests are failing given some resource limitations. I think the tests run on the cloud foundation team's CI projects. Do you know who might be able to help Hank here?
|
/gcbrun |
@Shabirmean it looks like stockout rather than quota? I suggest retrying it in a bit to see if it helps. If not we can ignore the failure or disable the test to unblock PRs. |
Re-ran the test and it passed? |
Looks like it is passing again, which is great. @bourgeoisor, as a code owner, can you approve so I can merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my end.
Description
Add samples demonstrating use of GKE attached clusters with both AKS and EKS. The samples: