Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add terraform samples for GKE Attached clusters. #667

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

hankfreund
Copy link
Member

Description

Add samples demonstrating use of GKE attached clusters with both AKS and EKS. The samples:

  1. create a cluster
  2. prepare the cluster for attach
  3. attach the cluster as a single Terraform apply step, which has been problematic for users.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 4, 2024
Copy link

conventional-commit-lint-gcf bot commented Apr 4, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Add samples demonstrating use of GKE attached clusters with both AKS and
EKS. The samples:
1. create a cluster
2. prepare the cluster for attach
3. attach the cluster
as a single Terraform apply step which has been problematic for users.
@hankfreund hankfreund changed the title improvement: Add terraform samples for GKE Attached clusters. feat: Add terraform samples for GKE Attached clusters. Apr 4, 2024
@hankfreund hankfreund marked this pull request as ready for review April 4, 2024 16:29
@hankfreund hankfreund requested review from yoshi-approver and a team as code owners April 4, 2024 16:29
@hankfreund
Copy link
Member Author

/gcbrun

@hdp617 hdp617 assigned hdp617 and unassigned hdp617 Apr 8, 2024
@hankfreund
Copy link
Member Author

/gcbrun

@Shabirmean
Copy link
Member

@bharathkkb the CI tests are failing given some resource limitations. I think the tests run on the cloud foundation team's CI projects. Do you know who might be able to help Hank here?

Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":        Error: Error waiting for instance to create: The zone 'projects/ci-abm-245d5a28-f04d/zones/us-central1-a' does not have enough resources available to fulfill the request.  '(resource type:compute)'.
Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":        A n1-standard-8 VM instance with 1 nvidia-tesla-k80 accelerator(s) is currently unavailable in the us-central1-a zone. Consider trying your request in the us-central1-c zone(s), which currently has capacity to accommodate your request. Alternatively, you can try your request again with a different VM hardware configuration or at a later time. For more information, see the troubleshooting documentation.
Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":        Troubleshooting documentation
Step #6 - "converge abm-gce-gpu":        https://cloud.google.com/compute/docs/resource-error
Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":          with module.anthos_bm_gcp.module.admin_vm_hosts.module.compute_instance["cluster1-abm-ws0"].google_compute_instance_from_template.compute_instance[0],
Step #6 - "converge abm-gce-gpu":          on .terraform/modules/anthos_bm_gcp.admin_vm_hosts.compute_instance/modules/compute_instance/main.tf line 45, in resource "google_compute_instance_from_template" "compute_instance":
Step #6 - "converge abm-gce-gpu":          45: resource "google_compute_instance_from_template" "compute_instance" {
Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":        Error: Error waiting for instance to create: The zone 'projects/ci-abm-245d5a28-f04d/zones/us-central1-a' does not have enough resources available to fulfill the request.  '(resource type:compute)'.
Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":        
Step #6 - "converge abm-gce-gpu":        A n1-standard-8 VM instance with 1 nvidia-tesla-k80 accelerator(s) is currently unavailable in the us-central1-a zone. Consider trying your request in the us-central1-c zone(s), which currently has capacity to accommodate your request. Alternatively, you can try your request again with a different VM hardware configuration or at a later time. For more information, see the troubleshooting documentation.
Step #6 - "converge abm-gce-gpu":        

@hankfreund
Copy link
Member Author

/gcbrun

@bharathkkb
Copy link
Member

@Shabirmean it looks like stockout rather than quota? I suggest retrying it in a bit to see if it helps. If not we can ignore the failure or disable the test to unblock PRs.

@bourgeoisor
Copy link
Member

Re-ran the test and it passed?

@hankfreund
Copy link
Member Author

Looks like it is passing again, which is great. @bourgeoisor, as a code owner, can you approve so I can merge?

Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end.

@bourgeoisor bourgeoisor merged commit 59a0d19 into GoogleCloudPlatform:main Apr 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants