Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [anthos-bm-gcp-terraform] parameterize ABM version #570

Merged
merged 3 commits into from
Feb 8, 2023
Merged

feat: [anthos-bm-gcp-terraform] parameterize ABM version #570

merged 3 commits into from
Feb 8, 2023

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Feb 6, 2023 •
edited
Loading

Description

  • Parameterize ABM version to a single abm_version variable rather than hard coded
  • Set default abm_version to 1.14.1
  • Updates the test to use abm_version instead of using hard coded

@apeabody apeabody requested a review from a team as a code owner February 6, 2023 21:51
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 6, 2023
@apeabody
Copy link
Collaborator Author

apeabody commented Feb 6, 2023

/gcbrun

@apeabody
Copy link
Collaborator Author

apeabody commented Feb 6, 2023

@Shabirmean - Can you please assist with /gcbrun ?

@Shabirmean
Copy link
Member

/gcbrun

@Shabirmean
Copy link
Member

Thank you very much @apeabody for this improvement. This makes it super easy!

Shabirmean
Shabirmean requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@Shabirmean Shabirmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the sample terraform.tfvars.sample file?

@Shabirmean
Copy link
Member

Also there is a linting error:

In ./anthos-bm-gcp-terraform/resources/init_vm.sh line 171:
  gsutil cp gs://anthos-baremetal-release/bmctl/$ABM_VERSION/linux-amd64/bmctl .
                                                ^----------^ SC2086: Double quote to prevent globbing and word splitting.

@apeabody
Copy link
Collaborator Author

apeabody commented Feb 7, 2023

Can we also update the sample terraform.tfvars.sample file?

Hi @Shabirmean - Are you thinking in addition, or instead of, the default value?

@Shabirmean
Copy link
Member

Can we also update the sample terraform.tfvars.sample file?

Hi Shabir Mohamed Abdul Samadh - Are you thinking in addition, or instead of, the default value?

I just now saw that you have a default value. I think that is enough, so that we just have one place to update when we do changes.

@Shabirmean
Copy link
Member

/gcbrun

@Shabirmean
Copy link
Member

/gcbrun

@apeabody apeabody changed the title feat: parameterize ABM version feat: [anthos-bm-gcp-terraform] parameterize ABM version Feb 7, 2023
@Shabirmean
Copy link
Member

/gcbrun

@Shabirmean Shabirmean merged commit c25163e into GoogleCloudPlatform:main Feb 8, 2023
@release-please release-please bot mentioned this pull request Feb 8, 2023
Merged
@apeabody apeabody mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shabirmean Shabirmean Shabirmean approved these changes

Assignees
No one assigned
Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeabody @Shabirmean