Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting specific Emscripten version to fix build #20

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

willmorgan
Copy link
Contributor

@willmorgan willmorgan commented Oct 2, 2020

Fixes #19

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@willmorgan
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@surma
Copy link
Contributor

surma commented Oct 2, 2020

Thank you. This is a good workaround for now.

I want to bring the code base up to date to build with the most recent Emscripten, but currently don’t have the time.

@surma surma merged commit 271bf27 into GoogleChromeLabs:master Oct 2, 2020
@willmorgan willmorgan deleted the patch-1 branch October 2, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build is failing with error "./libvpx.a: archive has no index; run ranlib to add one"
3 participants