Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Rustflags now require alsow +mutable-globals #9

Closed
Ciantic opened this issue Jul 18, 2021 · 2 comments · Fixed by #13
Closed

Rustflags now require alsow +mutable-globals #9

Ciantic opened this issue Jul 18, 2021 · 2 comments · Fixed by #13

Comments

@Ciantic
Copy link

Ciantic commented Jul 18, 2021

I spent quiet some time wondering about linker errors, looks like RUSTFLAGS with latest nightly needs also mutable-globals, e.g.

-C target-feature=+atomics,+bulk-memory,+mutable-globals

See e.g. rustwasm/wasm-bindgen#2487 and the appropriate fix alexcrichton/wasm-bindgen@ad53c12

@RReverser
Copy link
Contributor

looks like RUSTFLAGS with latest nightly needs also mutable-globals,

Yeah those things tend to change / break over time which is why the README specifically recommends a fixed nightly version. I suppose we can upgrade that version at some point + update the required flags though.

@RReverser
Copy link
Contributor

Actually, if you can find a nightly hash that corresponds to latest stable Rust (we do this to reduce risks), I'd be happy to accept a PR that updates the Rust version & required features.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants