Prevent including HTML entities in web app manifest name and description fields #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
deleted the
fix/html-entities-in-manifest-name-and-description
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried setting the blogname to:
And the manifest then erroneously included:
{"name":"WordPress & "Develop" and 'food' and \u201cdrink\u201d \ud83d\ude00")There are named entities which need to be decoded, which
wp_kses_decode_entities()doesn't do. So we need to usehtml_entity_decode()instead.After the changes here, the manifest then includes:
{"name":"WordPress & \"Develop\" and 'food' and \u201cdrink\u201d \ud83d\ude00"}