Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Turbo mode works seamlessly with force_uncompressed_tinymce in WP 5.0 #91

Open
westonruter opened this issue Oct 17, 2018 · 0 comments

Comments

@westonruter
Copy link
Collaborator

See phpDoc for force_uncompressed_tinymce in https://core.trac.wordpress.org/changeset/43738:

* Force uncompressed TinyMCE when a custom theme has been defined.
*
* The compressed TinyMCE file cannot deal with custom themes, so this makes
* sure that we use the uncompressed TinyMCE file if a theme is defined.
* Even if we are on a production environment.

With Turbo mode (#42) in the PWA plugin (where admin assets are precached) then this should be irrelevant. In other words, custom themes should not have a negative performance impact. This should be confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant