We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As requested on a support forum topic, some sites may want to load the Workbox scripts from a CDN instead of loading them from origin.
This is not currently supported, as seen here:
pwa-wp/wp-includes/components/class-wp-service-worker-configuration-component.php
Lines 55 to 79 in f9fc1cb
Perhaps this could be supported by allowing $options to be filtered in PHP.
$options
The text was updated successfully, but these errors were encountered:
Eventually this could be achieved by passing the paths through the includes_url() function so that it could be filtered.
includes_url()
Sorry, something went wrong.
For now, we can just make use of the plugins_url() function so that the plugins_url filter is applied to the Workbox URLs
plugins_url()
plugins_url
QA Passed ✅
To cross check this issue registered a new plugin and was able to load the Workbox.js scripts through CDN, as per the URL passed in the code.
Successfully merging a pull request may close this issue.
As requested on a support forum topic, some sites may want to load the Workbox scripts from a CDN instead of loading them from origin.
This is not currently supported, as seen here:
pwa-wp/wp-includes/components/class-wp-service-worker-configuration-component.php
Lines 55 to 79 in f9fc1cb
Perhaps this could be supported by allowing
$options
to be filtered in PHP.The text was updated successfully, but these errors were encountered: