Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of wp_service_worker_json_encode() #341

Closed
westonruter opened this issue Oct 13, 2020 · 0 comments · Fixed by #359
Closed

Eliminate use of wp_service_worker_json_encode() #341

westonruter opened this issue Oct 13, 2020 · 0 comments · Fixed by #359
Labels
changelogged enhancement New feature or request
Milestone

Comments

@westonruter
Copy link
Collaborator

The wp_service_worker_json_encode() function was added to automatically strip slashes and pretty-print. This was for the sake of manually inspecting the service worker JS. However, this adds additional bytes to the response. And in practice, pretty-printing is easily done in DevTools anyway.

So I want to eliminate the use of wp_service_worker_json_encode(). We can just remove it since no other plugins are using this function, but to be safe we can deprecate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelogged enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant