Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When “Update on reload” is checked, navigation blocked #249

Closed
westonruter opened this issue Mar 4, 2020 · 1 comment · Fixed by #279
Closed

When “Update on reload” is checked, navigation blocked #249

westonruter opened this issue Mar 4, 2020 · 1 comment · Fixed by #279
Labels
bug Something isn't working service-workers
Milestone

Comments

@westonruter
Copy link
Collaborator

westonruter commented Mar 4, 2020

When Chrome DevTools is open and “Update on reload” is checked in the Application tab:

image

Clicking around the site will result in the initial page just reloading. The cause is this code:

window.location.reload();

In reality, we should no longer be automatically reloading when the service worker updates. It just causes problems. See #205.

@westonruter
Copy link
Collaborator Author

I've opened a PR to fix this and have a build for testing: #279 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working service-workers
Projects
None yet
1 participant