! get_custom_header() in Custom_Header_Integration has no meaning

[szepeviktor]

get_custom_header returns an object, so ! object it always false.

Discovered by @phpstan on Level 4

[westonruter]

Are you referring to this code:

pwa-wp/integrations/class-wp-service-worker-custom-header-integration.php

Lines 57 to 58 in 37a3365

	$header = get_custom_header();
	$attachment = ! empty( $header->attachment_id ) ? get_post( get_custom_header()->attachment_id ) : null;

It's checking that the attachment_id is set, not the object as a whole.

[szepeviktor]

Rather this one:

pwa-wp/integrations/class-wp-service-worker-custom-header-integration.php

Lines 22 to 25 in 351eeec

	public function register( WP_Service_Worker_Scripts $scripts ) {
	if ( ! current_theme_supports( 'custom-header' ) || ! get_custom_header() ) {
	return;
	}

[westonruter]

The integrations will be deprecated per #403 so I'm closing this.